| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Parallel safety for extern params |
| Date: | 2025-03-21 19:23:38 |
| Message-ID: | CA+TgmoYx8bSrF2h1Kw5jNaFtDwBAy69=wmAsEm13TUHoXh=12g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 21, 2025 at 1:41 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> (and similarly in fix_upper_expr_mutator). So actually, I had broken
> setrefs.c's matching of Params to lower plan levels with the
> multi-assignment business, and Amit was dodging that breakage.
> But this change is still wrong in itself: if anything, it should
> have returned the Param, not treated it as a reference to the
> child plan.
Ah ha! Well, that makes me feel a bit better -- perhaps what I
committed wasn't the right way to fix it, but at least I wasn't just
committing stuff totally at random.
I'm happy to have you tidy up here in whatever way seems best to you.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-03-21 19:23:50 | Re: Using read_stream in index vacuum |
| Previous Message | Robert Haas | 2025-03-21 19:23:09 | apprelids |