| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Noah Misch <noah(at)leadboat(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2025-02-14 00:56:40 |
| Message-ID: | CAAKRu_YXvG0UG7a3umfRHEy=DJ6s4MK8wTXXVC_YFVQ4wwaPoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2025 at 6:52 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> I've been poking, reading, and trying out these patches. They look good to me.
Thanks for the review.
> Tiny nit, maybe this comment could say something less obvious, cf the
> similar comment near the other stream:
>
> + /* Set up the read stream */
> + stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE,
Done in upthread v18.
> I don't really love the cumbersome casting required around
> per_buffer_data, but that's not your patches' fault (hmm, wonder what
> we can do to improve that).
I don't know if you saw v17, but I tried to improve it a bit. The
casting still has to happen, but I at least use the variable as a
uint8 instead of a pointer to a uint8 (dunno if that makes it better
or worse). It is the same in v18.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Atkinson | 2025-02-14 01:04:46 | Re: DROP CONSTRAINT, printing a notice and/or skipping when no action is taken |
| Previous Message | Melanie Plageman | 2025-02-14 00:54:52 | Re: Confine vacuum skip logic to lazy_scan_skip |