| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Noah Misch <noah(at)leadboat(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2025-02-13 23:51:47 |
| Message-ID: | CA+hUKGJSZbFfcg7a7x50Q_8b9_iv_ycXUuMY2Wjm5ar_UgVzOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 14, 2025 at 12:11 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
> I've done some clean-up including incorporating a few off-list pieces
> of minor feedback from Andres.
I've been poking, reading, and trying out these patches. They look good to me.
Tiny nit, maybe this comment could say something less obvious, cf the
similar comment near the other stream:
+ /* Set up the read stream */
+ stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE,
I don't really love the cumbersome casting required around
per_buffer_data, but that's not your patches' fault (hmm, wonder what
we can do to improve that).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-14 00:03:08 | Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible |
| Previous Message | Hannu Krosing | 2025-02-13 23:37:34 | Re: Is pgAdmin the only front-end to PostgreSQL debugger ? And is "a working pl/pgsql debugger" something core should care to maintain ? |