Re: ALTER INDEX ... ALTER COLUMN not present in dump

On Mon, Dec 17, 2018 at 12:20 PM amul sul <sulamul(at)gmail(dot)com> wrote:

> On Mon, Dec 17, 2018 at 11:54 AM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
> >
> > On Mon, Dec 17, 2018 at 12:24:15AM -0500, Tom Lane wrote:
> > > If we were to rename the "foo.expr" column at this point,
> > > and then dump and reload, the expression column in the
> > > second index would presumably acquire the name "expr"
> > > not "expr1", because "expr" would no longer be taken.
> > > So if pg_dump were to try to use that index column name
> > > in ALTER ... SET STATISTICS, it'd fail.
> >
> > Good point, thanks! I did not think about the case where a table uses
> > an attribute name matching what would be generated for indexes.
> >
> > So this settles the argument that we had better not do anything before
> > v11. Switching the dump code to use column numbers has not proved to be
> > complicated as only the query and some comments had to be tweaked.
> > Attached is an updated patch, and I am switching back the patch to
> > "Needs review" to have an extra pair of eyes look at that in case I
> > missed something.
>
> +1, will have a look, thanks.
>
>
I been through the patch -- looks good and does the expected job as
discussed.

make check and make check-world also fine.

Regards,
Amul