| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Date: | 2018-12-17 19:24:08 |
| Message-ID: | 29223.1545074648@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
amul sul <sulamul(at)gmail(dot)com> writes:
>> On Mon, Dec 17, 2018 at 11:54 AM Michael Paquier <michael(at)paquier(dot)xyz>
>>> So this settles the argument that we had better not do anything before
>>> v11. Switching the dump code to use column numbers has not proved to be
>>> complicated as only the query and some comments had to be tweaked.
>>> Attached is an updated patch, and I am switching back the patch to
>>> "Needs review" to have an extra pair of eyes look at that in case I
>>> missed something.
> I been through the patch -- looks good and does the expected job as
> discussed.
I eyeballed the patch, and it seems reasonable to me as well. The test
case could perhaps be made more extensive (say, a multicolumn index
with a mix of columns with and without stats targets) but I'm not sure
that it's worth the trouble.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-12-17 19:29:14 | Re: BUG #15556: Duplicate key violations even when using ON CONFLICT DO UPDATE |
| Previous Message | Peter Geoghegan | 2018-12-17 19:08:43 | Re: BUG #15556: Duplicate key violations even when using ON CONFLICT DO UPDATE |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-12-17 19:42:50 | Re: don't create storage when unnecessary |
| Previous Message | Alvaro Herrera | 2018-12-17 19:21:18 | Re: Should new partitions inherit their tablespace from their parent? |