| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: pg_combinebackup: correct code comment. |
| Date: | 2025-04-15 10:41:19 |
| Message-ID: | CAAJ_b96YiKnS1Gw2qbAj6=u0Dv7Z6oCqz4iqF_eeVDQNqeBcgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 15, 2025 at 1:16 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed. The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID
>
+1
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2025-04-15 11:01:45 | Re: Built-in Raft replication |
| Previous Message | Ashutosh Bapat | 2025-04-15 10:38:56 | Re: Fundamental scheduling bug in parallel restore of partitioned tables |