Re: pg_combinebackup: correct code comment.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: pg_combinebackup: correct code comment.
Date: 2025-04-15 07:45:32
Message-ID: 713CFD44-BE8E-4CA7-81FE-F91BE48E5874@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Apr 2025, at 06:22, Amul Sul <sulamul(at)gmail(dot)com> wrote:

> Attached is a patch that corrects the code comment for
> process_directory_recursively() in pg_combinebackup, where the comment
> incorrectly refers to "output_directory" instead of the intended
> "input_directory".

Agreed. The second paragraph in the comment also seem a bit odd, how about the
below while we are there fixing things?

- * If processing is a user-defined tablespace, the tsoid should be the OID
+ * If processing a user-defined tablespace, the tsoid should be the OID

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-04-15 08:02:51 Re: use correct variable in error message in _allocAH function (pg_backup_archiver.c)
Previous Message Umar Hayat 2025-04-15 07:33:52 Re: New committer: Jacob Champion