| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Joel Jacobson <joel(at)compiler(dot)org> |
| Subject: | Re: NOT ENFORCED constraint feature |
| Date: | 2025-02-03 04:09:25 |
| Message-ID: | CAAJ_b95snSr7+q7VCh-7pcriTVtOeEh0Yc7QUWVbC_+RmUNUQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 1, 2025 at 8:31 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> [...]
> So the code should only call AlterConstrTriggerDeferrability,
> not call ATExecAlterConstrEnforceability?
Right. Thank you for the report. We need to know whether the
enforceability and/or deferability has actually been set or not before
catalog update.
Have you started working on the ALTER ... CONSTRAINT for the check
constraint? I am thinking to start that. To fix this bug, we have two
options: we could either throw an error as we don’t currently support
altering enforceability and deferability together (which I’m not a fan
of), or we could refactor the ALTER ... CONSTRAINT code to include
more information which would allow us to perform the appropriate
update action during the execution stage, and it would also help with
altering check constraints.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-02-03 04:11:02 | Re: Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary |
| Previous Message | Michael Paquier | 2025-02-03 04:07:26 | Re: Show WAL write and fsync stats in pg_stat_io |