Re: NOT ENFORCED constraint feature

From: Amul Sul <sulamul(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Joel Jacobson <joel(at)compiler(dot)org>
Subject: Re: NOT ENFORCED constraint feature
Date: 2025-02-04 10:34:57
Message-ID: CAAJ_b94XyykeV9U01jUs64F-tXtuKr7Ac2T74ieu1JQyicKS=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 3, 2025 at 9:39 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> On Sat, Feb 1, 2025 at 8:31 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > [...]
> > So the code should only call AlterConstrTriggerDeferrability,
> > not call ATExecAlterConstrEnforceability?
>
> Right. Thank you for the report. We need to know whether the
> enforceability and/or deferability has actually been set or not before
> catalog update.
>

Fixed in the attached version. A new patch, 0001, introduces a new
struct, AlterConstraintStmt, which carries the necessary information
for enforceability and deferrability modifications of a constraint, as
implemented in patch 0006.

Regards,
Amul

Attachment Content-Type Size
v12-0001-Add-AlterConstraintStmt-struct-for-ALTER-.-CONST.patch application/octet-stream 6.5 KB
v12-0002-refactor-Split-tryAttachPartitionForeignKey.patch application/octet-stream 13.5 KB
v12-0003-refactor-Pass-Relid-instead-of-Relation-to-creat.patch application/octet-stream 3.3 KB
v12-0004-refactor-Change-ATExecAlterConstrRecurse-argumen.patch application/octet-stream 5.3 KB
v12-0005-Remove-hastriggers-flag-check-before-fetching-FK.patch application/octet-stream 10.8 KB
v12-0006-Add-support-for-NOT-ENFORCED-in-foreign-key-cons.patch application/octet-stream 62.2 KB
v12-0007-Merge-the-parent-and-child-constraints-with-diff.patch application/octet-stream 18.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yura Sokolov 2025-02-04 10:36:39 Re: sinvaladt.c: remove msgnumLock, use atomic operations on maxMsgNum
Previous Message Nisha Moond 2025-02-04 10:27:51 Re: Introduce XID age and inactive timeout based replication slot invalidation