Re: pgsql: Use better comment marker in Autoconf input

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <munro(at)ip9(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Use better comment marker in Autoconf input
Date: 2019-02-11 20:52:57
Message-ID: CAA8=A79X26pNCUVHr5myEUhxmSLjXwh41=bqdUVtj4KnVoAOCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Feb 11, 2019 at 11:46 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Yup, the buildfarm script only knows to nuke it if "configure" changes.
> If you change the critter's buildfarm parameters, or the build
> environment, that might require revisiting configure tests, but it won't
> happen automatically. I can't think of any really easy way to improve
> that.
>

Could stash a checksum of the config settings and obsolete the cache
if there was a mismatch. The danger is that we could get some false
positives, but the only downside to that is a one time extra amount of
time spent in configure.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-02-11 21:18:20 pgsql: Stamp 11.2.
Previous Message Thomas Munro 2019-02-11 20:35:43 Re: pgsql: Use better comment marker in Autoconf input