| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal to CREATE FOREIGN TABLE LIKE |
| Date: | 2025-02-11 16:07:48 |
| Message-ID: | CAA5RZ0vsbWeNo9MT7xT_3vaDLJU7Uumn4HUU3aqUVbZ7G7YK4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> + Foreign tables have no real storage in PostgreSQL.
> + Inapplicable options: <literal>INCLUDING INDEXES</literal>,
> <literal>INCLUDING STORAGE</literal>,
>
> Oh, I corrected another one in the code comments, but I forgot about this one.
> Done in patch v3.
I attached v4 with some slight modifications to the wording, otherwise
this looks good.
>> I think the test coverage to check for the negative conditions only is
>> enough.
>>
>>
> Hmm... I copied from the cases in the same file for each option.
> There's no harm in having more tests, how about we keep them?
I agree. I was just saying the test cases you provided are
enough. No changes needed for the tests.
I have no further comments.
Regards,
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-CREATE-FOREIGN-TABLE-LIKE.patch | application/octet-stream | 22.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-02-11 16:09:26 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Andres Freund | 2025-02-11 16:06:27 | Re: Eagerly scan all-visible pages to amortize aggressive vacuum |