| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal to CREATE FOREIGN TABLE LIKE |
| Date: | 2025-02-11 14:49:24 |
| Message-ID: | 532c4759-52d4-46c9-8eb2-6a836e3ece22@Spark |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 11, 2025 at 08:14 +0800, Sami Imseih <samimseih(at)gmail(dot)com>, wrote:
> > Patch V2 addressed the comments.
> >
> > Overall this LGTM.
> >
> > I still see a "no real storage" in v2 that should be removed
> > from the documentation.
> >
> > + Foreign tables have no real storage in PostgreSQL.
> > + Inapplicable options: <literal>INCLUDING INDEXES</literal>,
> > <literal>INCLUDING STORAGE</literal>,
Oh, I corrected another one in the code comments, but I forgot about this one.
Done in patch v3.
>
>
> I think the test coverage to check for the negative conditions only is
> enough.
Hmm... I copied from the cases in the same file for each option.
There's no harm in having more tests, how about we keep them?
--
Zhang Mingli
HashData
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-CREATE-FOREIGN-TABLE-LIKE.patch | application/octet-stream | 22.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-02-11 14:51:28 | Re: explain analyze rows=%.0f |
| Previous Message | Álvaro Herrera | 2025-02-11 14:22:49 | Re: Introduce XID age and inactive timeout based replication slot invalidation |