| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Shayon Mukherjee <shayonj(at)gmail(dot)com> |
| Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, David Rowley <dgrowleyml(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Re: Proposal to Enable/Disable Index using ALTER INDEX |
| Date: | 2025-04-07 20:01:33 |
| Message-ID: | CAA5RZ0tvdenXt29KLECKVGMcN1S=N4Nw-6OEQxUDuu3Nm7+hMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the update!
The changes in v15 look good to me. The patch does need to be rebased,
and I also think you should add a tab-complete for CREATE INDEX
simseih(at)bcd07415af92 postgresql % git diff
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 8e2eb50205e..f1853a68ccc 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -3434,6 +3434,8 @@ match_previous_words(int pattern_id,
!TailMatches("POLICY", MatchAny, MatchAny,
MatchAny, MatchAny, MatchAny) &&
!TailMatches("FOR", MatchAny, MatchAny, MatchAny))
COMPLETE_WITH("(");
+ else if (TailMatches("*)"))
+ COMPLETE_WITH("VISIBLE", "INVISIBLE");
/* CREATE OR REPLACE */
else if (Matches("CREATE", "OR"))
IMO, with the above in place, this patch is RFC.
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-04-07 20:27:30 | Re: track generic and custom plans in pg_stat_statements |
| Previous Message | Tom Lane | 2025-04-07 19:57:25 | Re: [fixed] Trigger test |