Re: Usage of ProcessConfigfile in SIGHUP_Handler

From: Lakshmi Narayana Velayudam <dev(dot)narayana(dot)v(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Usage of ProcessConfigfile in SIGHUP_Handler
Date: 2024-08-22 16:00:05
Message-ID: CAA4pTnJCKav=2WYyLEc+eiQO0FEGFfrRqNsUOY4aMPynUk7H3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 22, 2024 at 8:46 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:

>
> > I think this is no longer true as of v16, thanks to commit 7389aad [0].
>

My Bad Nathan, was looking at PG 11, 14 codes. Just to be sure, calling
*ProcessConfigFile *is a bug from a signal handler is a bug, right? Since
it uses AllocSetContextCreate & also GUC variables changes might not be
visible in regular flow.

I saw the discussion of the commit but couldn't conclude from the
discussion that it was changed due to *ProcessConfigFIle. *

Regards,
Narayana

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amonson, Paul D 2024-08-22 16:19:20 RE: Proposal for Updating CRC32C with AVX-512 Algorithm.
Previous Message Nathan Bossart 2024-08-22 15:29:00 Re: Proposal for Updating CRC32C with AVX-512 Algorithm.