From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera from 2ndQuadrant <alvherre(at)alvh(dot)no-ip(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com> |
Subject: | Re: [HACKERS] [PATCH] pageinspect function to decode infomasks |
Date: | 2019-09-14 04:21:33 |
Message-ID: | CAA4eK1LwdPFNNkW1=aJn9eE2Pi_YnPZGov--kQ1Z5M6cpOHe4g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 13, 2019 at 10:42 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Sep 13, 2019 at 09:59:40AM +0530, Amit Kapila wrote:
> > I think that is what we have not done in one of the cases pointed by me.
>
> Thinking more about it, I see your point now. HEAP_LOCKED_UPGRADED is
> not a direct combination of the other flags and depends on other
> conditions, so we cannot make a combination of it with other things.
> The three others don't have that problem.
>
> Attached is a patch to fix your suggestions. This also removes the
> use of HEAP_XMAX_IS_LOCKED_ONLY which did not make completely sense
> either as a "raw" flag. While on it, the order of the flags can be
> improved to match more the order of htup_details.h
>
> Does this patch address your concerns?
>
Yeah, but I think we should also try to see what we want to do about
'decode_combined' flag-related point, maybe we can adapt to what
Alvaro has purposed?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-14 04:25:20 | Re: BF failure: could not open relation with OID XXXX while querying pg_views |
Previous Message | Michael Paquier | 2019-09-14 04:20:06 | Re: pg_rewind docs correction |