| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() |
| Date: | 2021-09-06 10:34:40 |
| Message-ID: | CAA4eK1LfzPdTO73vW2qUkJeB1k1iL04rmqVJseBbF5qRAonmiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 13, 2021 at 3:15 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
>
>
> Please find attached a patch proposal to avoid the failed assertion (by ensuring that ReorderBufferChangeMemoryUpdate() being triggered with "addition" set to false in ReorderBufferToastReplace() is done after the elog(ERROR,)).
>
The error can occur at multiple places (like via palloc or various
other places) between the first time we subtract the change_size and
add it back after the change is re-computed. I think the correct fix
would be that in the beginning we just compute the change_size by
ReorderBufferChangeSize and then after re-computing the change, we
just subtract the old change_size and add the new change_size. What do
you think?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gkokolatos | 2021-09-06 11:39:51 | Re: psql: \dl+ to list large objects privileges |
| Previous Message | Aleksander Alekseev | 2021-09-06 10:10:01 | Re: Patch: shouldn't timezone(text, timestamp[tz]) be STABLE? |