From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Subject: | Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate() |
Date: | 2021-09-13 16:52:39 |
Message-ID: | 202109131652.i2mpy2tgxumt@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021-Sep-06, Amit Kapila wrote:
> The error can occur at multiple places (like via palloc or various
> other places) between the first time we subtract the change_size and
> add it back after the change is re-computed. I think the correct fix
> would be that in the beginning we just compute the change_size by
> ReorderBufferChangeSize and then after re-computing the change, we
> just subtract the old change_size and add the new change_size. What do
> you think?
Am I the only that that thinks this code is doing far too much in a
PG_CATCH block?
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Those who use electric razors are infidels destined to burn in hell while
we drink from rivers of beer, download free vids and mingle with naked
well shaved babes." (http://slashdot.org/comments.pl?sid=44793&cid=4647152)
From | Date | Subject | |
---|---|---|---|
Next Message | Matthias van de Meent | 2021-09-13 17:12:42 | Re: 64 bit TID? |
Previous Message | Alvaro Herrera | 2021-09-13 16:51:17 | Re: Numeric x^y for negative x |