From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
Cc: | Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallel execution and prepared statements |
Date: | 2016-11-29 10:09:04 |
Message-ID: | CAA4eK1LXDsC-qS1Kvd9KbtH4ot=VDsZyP1xk2C2m-TSspYumVg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 18, 2016 at 9:01 PM, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> wrote:
> Amit Kapila wrote:
>> Can you once test by just passing CURSOR_OPT_PARALLEL_OK in
>> PrepareQuery() and run the tests by having forc_parallel_mode=regress?
>> It seems to me that the code in the planner is changed for setting a
>> parallelModeNeeded flag, so it might work as it is.
>
> No, that doesn't work.
>
> But with Tobias' complete patch "make installcheck-world" succeeds.
>
Okay. I have looked into patch proposed and found that it will
resolve the regression test problem (Create Table .. AS Execute). I
think it is slightly prone to breakage if tomorrow we implement usage
of EXECUTE with statements other Create Table (like Copy). Have you
registered this patch in CF to avoid loosing track?
We have two patches (one proposed in this thread and one proposed by
me earlier [1]) and both solves the regression test failure. Unless
there is some better approach, I think we can go with one of these.
[1] - https://www.postgresql.org/message-id/CAA4eK1L%3DtHmmHDK_KW_ja1_dusJxJF%2BSGQHi%3DAPS4MdNPk7HFQ%40mail.gmail.com
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2016-11-29 10:11:44 | Re: commitfest 2016-11 status summary |
Previous Message | Pavel Stehule | 2016-11-29 09:43:33 | Re: PSQL commands: \quit_if, \quit_unless |