| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: LogicalChanges* and LogicalSubxact* wait events are never reported |
| Date: | 2021-10-20 09:17:45 |
| Message-ID: | CAA4eK1LNBQtcywY7-YHKBuLV3TfGn8E_uAXMDDi9j4TE0O0Bww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote:
> > If my understanding is right, it's better to remove them since they make
> > users confused. Please see the attached patch. I confirmed that to make
> > check-world passes all tests.
>
> Yeah, I don't see the point in keeping these events around if they are
> not used. Perhaps Amit has some plans for them, though.
>
No, there is no plan for these. As far as I remember, during
development, we have decided to use BufFile interface and forgot to
remove these events which were required by the previous versions of
the patch. I'll take care of this.
Thanks for the report and patch!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-10-20 09:33:17 | Re: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Greg Nancarrow | 2021-10-20 09:00:18 | Re: Data is copied twice when specifying both child and parent table in publication |