| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: LogicalChanges* and LogicalSubxact* wait events are never reported |
| Date: | 2021-10-20 10:16:20 |
| Message-ID: | 3d68e948-e1ae-bb27-94da-43863ec3ace3@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/10/20 18:17, Amit Kapila wrote:
> On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>
>> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote:
>>> If my understanding is right, it's better to remove them since they make
>>> users confused. Please see the attached patch. I confirmed that to make
>>> check-world passes all tests.
>>
>> Yeah, I don't see the point in keeping these events around if they are
>> not used. Perhaps Amit has some plans for them, though.
>>
>
> No, there is no plan for these. As far as I remember, during
> development, we have decided to use BufFile interface and forgot to
> remove these events which were required by the previous versions of
> the patch. I'll take care of this.
>
> Thanks for the report and patch!
Thanks for your replies and for handling it!
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-20 10:19:46 | Re: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Aleksander Alekseev | 2021-10-20 10:01:31 | [PATCH] Fix memory corruption in pg_shdepend.c |