| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix slot synchronization with two_phase decoding enabled |
| Date: | 2025-04-01 06:09:10 |
| Message-ID: | CAA4eK1L7uyJAEJGBEXAYehyG_gfvuQLh5FDqDRf+uJaDT=HggA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 31, 2025 at 5:04 PM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Thanks for the comments, they have been addressed in V2.
>
In the PG17 patch, we only have a check preventing failover and
two_phase in CreateSubscription. Don't we need a similar check for
AlterSubscription?
Apart from the above, I have a few suggestions for changes in docs,
error messages, and comments for both versions. See attached.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Head-amit.1.patch.txt | text/plain | 1.6 KB |
| v2-0001-PG17-amit.1.patch.txt | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-04-01 06:22:41 | Re: Test to dump and restore objects left behind by regression |
| Previous Message | Mahendra Singh Thalor | 2025-04-01 05:59:43 | Re: Non-text mode for pg_dumpall |