Re: unnecessary creation of FSM files during bootstrap mode

On Fri, Jan 11, 2019 at 5:00 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It's also possible that you just aren't exercising the cases where
> trouble occurs. In particular, noting this bit in InsertOneValue():
>
> /*
> * We use ereport not elog here so that parameters aren't evaluated unless
> * the message is going to be printed, which generally it isn't
> */
> ereport(DEBUG4,
> (errmsg_internal("inserted -> %s",
> OidOutputFunctionCall(typoutput, values[i]))));
>
> I'd counsel running initdb under DEBUG4 or higher before deciding
> you're out of the woods.
>

I have tried initdb with --debug option (If I am not wrong, it runs
initdb under DEBUG5 mode) and didn't hit any problem after applying
the patch. Are you expecting that we might try to open pg_proc at
that place which can lead to the problem?

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com