| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | John Naylor <jcnaylor(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: unnecessary creation of FSM files during bootstrap mode |
| Date: | 2019-01-11 14:31:24 |
| Message-ID: | 693.1547217084@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Fri, Jan 11, 2019 at 5:00 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It's also possible that you just aren't exercising the cases where
>> trouble occurs. In particular, noting this bit in InsertOneValue():
>> OidOutputFunctionCall(typoutput, values[i]))));
> I have tried initdb with --debug option (If I am not wrong, it runs
> initdb under DEBUG5 mode) and didn't hit any problem after applying
> the patch. Are you expecting that we might try to open pg_proc at
> that place which can lead to the problem?
Yes, I was concerned about regprocout in particular. It might be
okay as long as we don't try to add any regproc columns to the
BKI_BOOTSTRAP catalogs.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-11 14:42:19 | Re: Acceptable/Best formatting of callbacks (for pluggable storage) |
| Previous Message | Peter Eisentraut | 2019-01-11 14:09:45 | Re: port of INSTALL file generation to XSLT |