Re: Fix GetOldestXmin comment

On Tue, May 30, 2017 at 6:32 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Hi,
>
> While reading source code, I realized that comment of GetOldestXmin mentions;
>
> * if rel = NULL and there are no transactions running in the current
> * database, GetOldestXmin() returns latestCompletedXid.
>
> However, in that case if I understand correctly GetOldestXmin()
> actually returns latestCompletedXid + 1 as follows;
>

Isn't there another gotcha in above part of the comment, shouldn't it
say rel != NULL? AFAICS, when rel is NULL, it considers all databases
not only current database.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com