| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Jason Petersen <jason(at)citusdata(dot)com>, pgsql-pkg-debian(at)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x |
| Date: | 2017-05-30 14:02:56 |
| Message-ID: | CA+TgmoYk0eSy=wfiusUHsZvN+NF+R4RaoJic0y=Rz3ErKhwzyA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-pkg-debian |
On Mon, May 29, 2017 at 3:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wonder what the overhead is of using -fPIC when -fpic would be
> sufficient. Whatever it is, the proposed patch imposes it on every
> shlib or extension, to accommodate one single extension that isn't
> even one we ship.
>
> Maybe this is small enough to not be something we need to worry about,
> but I'm wondering if we should ask citus and other large .so's to set
> some additional make flag that would cue usage of -fPIC over -fpic.
Do we have an idea how to measure the increased overhead? Just from
reading the description, I'm guessing that the increased cost would
happen when the extension calls back into core, but maybe that doesn't
happen often enough to worry about?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-05-30 14:07:21 | Re: Fix GetOldestXmin comment |
| Previous Message | Petr Jelinek | 2017-05-30 13:44:25 | Re: Walsender timeouts and large transactions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-30 14:12:46 | Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x |
| Previous Message | Tom Lane | 2017-05-29 19:45:11 | Re: [PATCH] relocation truncated to fit: citus build failure on s390x |