| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-10-25 10:51:26 |
| Message-ID: | CAA4eK1KjCUx6=QcNYsgy8s2S-H1j8ty7DLTVw+pe=DPsPmXypA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Oct 21, 2021 at 11:20 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Thu, Oct 21, 2021 at 9:11 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
>
> v5-0001, incorporates all the comment fixes suggested by Alvaro. and
> 0001 is an additional patch which moves
> MarkCurrentTransactionIdLoggedIfAny(), out of the critical section.
>
Thanks, both your patches look good to me except that we need to
remove the sentence related to the revert of ade24dab97 from the
commit message. I think we should backpatch the first patch to 14
where it was introduced and commit the second patch (related to moving
code out of critical section) only to HEAD but we can even backpatch
the second one till 9.6 for the sake of consistency. What do you guys
think?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-10-25 14:43:27 | pgsql: StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportPa |
| Previous Message | Heikki Linnakangas | 2021-10-25 06:32:58 | pgsql: Clarify the logic in a few places in the new balanced merge code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-10-25 11:06:29 | Re: Improve the HINT message of the ALTER command for postgres_fdw |
| Previous Message | Michael Paquier | 2021-10-25 10:49:08 | Re: pg_receivewal starting position |