| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-23 11:33:39 |
| Message-ID: | CAA4eK1KfZYTD8Hpi9TD1KaB8rNUBR9baUvTxa5wYyZDGbEaa6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 23, 2025 at 11:18 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Patch v56-0001 LGTM.
>
I have pushed this patch with minor modifications (especially I didn't
took Peter Smith's last suggestion to convert some functions to return
enum instead of char as the proposed one was consistent with
subscription side code and avoided casting in the patch). On of the BF
failed
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2025-01-23%2010%3A17%3A03
pg_dump: error: query failed: ERROR: column "publish_gencols_none"
does not exist
LINE 1: ...elete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GE...
^
pg_dump: detail: Query was: SELECT p.tableoid, p.oid, p.pubname,
p.pubowner, p.puballtables, p.pubinsert, p.pubupdate, p.pubdelete,
false AS pubtruncate, false AS pubviaroot, PUBLISH_GENCOLS_NONE AS
pubgencols_type FROM pg_publication p
pg_dumpall: error: pg_dump failed on database "template1", exiting
It is probably the case with dump/restore of previous versions. I'll
look into this.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-01-23 11:38:59 | Re: Convert macros to static inline functions |
| Previous Message | Ashutosh Bapat | 2025-01-23 11:33:36 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |