From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Convert macros to static inline functions |
Date: | 2025-01-23 11:38:59 |
Message-ID: | 3dfbd51a-ad90-4418-9c66-ec85d5a2cbdd@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 27.12.24 11:16, Peter Eisentraut wrote:
> On 16.05.22 10:27, Peter Eisentraut wrote:
>> Inspired by [0], I looked to convert more macros to inline functions.
>
> This is an older thread where I left something unfinished:
>
>> Note 2: Many macros in htup_details.h operate both on HeapTupleHeader
>> and on MinimalTuple, so converting them to a function doesn't work in
>> a straightforward way. I have some in-progress work in that area, but
>> I have not included any of that here.
>
> Here is the patch set for this.
I have committed this.
> There are actually only two macros that operate on both HeapTupleHeader
> and MinimalTuple, so it wasn't as much as I had written above. I just
> left those as macros. I converted the rest to inline functions in a
> straightforward way as before. A small amount of reordering was necessary.
>
> But just for language-nerd fun, I'm including here an additional patch
> showing how the remaining ones could be done with C11 generic selection.
> I'm not planning to commit that one at this time.
... except this.
From | Date | Subject | |
---|---|---|---|
Next Message | Zhijie Hou (Fujitsu) | 2025-01-23 11:47:05 | RE: Conflict detection for update_deleted in logical replication |
Previous Message | Amit Kapila | 2025-01-23 11:33:39 | Re: Pgoutput not capturing the generated columns |