| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description |
| Date: | 2024-09-03 05:13:14 |
| Message-ID: | CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 2, 2024 at 9:14 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Mon, Sep 2, 2024 at 5:47 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > ----
> >
> > To summarize, the current description wrongly describes the field as a
> > time duration:
> > "The time since the slot has become inactive."
> >
> > I suggest replacing it with:
> > "The slot has been inactive since this time."
> >
>
> +1 for the change. If I had read the document without knowing about
> the patch, I too would have interpreted it as a duration.
>
The suggested change looks good to me as well. I'll wait for a day or
two before pushing to see if anyone thinks otherwise.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-09-03 05:24:32 | Re: Typos in the code and README |
| Previous Message | David Rowley | 2024-09-03 05:05:55 | Re: Make tuple deformation faster |