| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-10-27 05:39:01 |
| Message-ID: | CAA4eK1JcgAgj_XMBaYr=DkQ1669FLYLGSiA-FUPkuRmQYXGaqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 27, 2023 at 10:43 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 27, 2023 at 04:40:43AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > Yeah, Bharath has already reported, I agreed that the reason was [1].
> >
> > ```
> > In the Windows API (with some exceptions discussed in the following paragraphs),
> > the maximum length for a path is MAX_PATH, which is defined as 260 characters.
> > ```
>
> - "invalid_logical_replication_slots.txt");
> + "invalid_logical_slots.txt");
>
> Or you could do something even shorter, with "invalid_slots.txt".
>
I also thought of it but if we want to keep it that way, we should
slightly adjust the messages like: "The slot \"%s\" is invalid" to
include slot_type. This will contain only logical slots, so the
current one probably seems okay.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-10-27 05:49:21 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Kyotaro Horiguchi | 2023-10-27 05:35:12 | Re: A recent message added to pg_upgade |