Re: Replication slot stats misgivings

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Replication slot stats misgivings
Date: 2021-04-15 09:16:35
Message-ID: CAA4eK1JbUeJKWcMdM2rkvsc_mp5a8-uSbgBFXQjJAc-WHkvN6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 15, 2021 at 1:13 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Apr 15, 2021 at 3:22 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> Thank you for updating the patch.
>
> I have one question on the doc change:
>
> + so the counter is not incremented for subtransactions. Note that this
> + includes the transactions streamed and or spilled.
> + </para></entry>
>
> The patch uses the sentence "streamed and or spilled" in two places.
> You meant “streamed and spilled”? Even if it actually means “and or”,
> using "and or” (i.g., connecting “and” to “or” by a space) is general?
> I could not find we use it other places in the doc but found we're
> using "and/or" instead.
>

I changed it to 'and/or' and made another minor change.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v12-0001-Add-information-of-total-data-processed-to-repli.patch application/octet-stream 25.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Luc Vlaming 2021-04-15 09:33:56 Re: "could not find pathkey item to sort" for TPC-DS queries 94-96
Previous Message shawn wang 2021-04-15 08:48:53 Re: [Proposal] Global temporary tables