Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases
Date: 2023-06-17 09:44:51
Message-ID: CAA4eK1JWPSXit2BU76LaBGvSCZmanLrzm64=4Uek6zoQqDXEXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 16, 2023 at 8:00 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, May 11, 2023 at 5:12 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
>
> After thinking more about it, I realized that this is not a problem
> specific to HEAD. ISTM the problem is that by commit 7b64e4b3, we drop
> the stats entry of subscription that is not associated with a
> replication slot for apply worker, but we missed the case where the
> subscription is not associated with both replication slots for apply
> and tablesync. So IIUC we should backpatch it down to 15.
>

I agree that it should be backpatched to 15.

> Since in pg15, since we don't create the subscription stats at CREATE
> SUBSCRIPTION time but do when the first error is reported,
>

AFAICS, the call to pgstat_create_subscription() is present in
CreateSubscription() in 15 as well, so, I don't get your point.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2023-06-17 11:48:39 Re: Incorrect estimation of HashJoin rows resulted from inaccurate small table statistics
Previous Message Amit Kapila 2023-06-17 06:33:22 Re: [DOC] Update ALTER SUBSCRIPTION documentation v3