From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: INSERT INTO SELECT, Why Parallelism is not selected? |
Date: | 2020-07-25 03:48:10 |
Message-ID: | CAA4eK1JPCd=GowHHkpri=T4KG6DrJnDj-u4nh434YCyR5cu3vw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 24, 2020 at 7:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Well, I think the comments could be more clear - for the insert case
> > specifically - about which cases you think are and are not safe.
>
Okay, I'll update the patch accordingly.
> Yeah, the proposed comment changes don't actually add much. Also
> please try to avoid inserting non-ASCII into the source code;
> at least in my mail reader, that attachment has some.
>
I don't see any non-ASCII characters in the patch. I have applied and
checked (via vi editor) the patch as well but don't see any non-ASCII
characters. How can I verify that?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-07-25 09:17:42 | Re: handle a ECPG_bytea typo |
Previous Message | Pavel Stehule | 2020-07-25 03:40:08 | Re: Row estimates for empty tables |