| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: handle a ECPG_bytea typo |
| Date: | 2020-07-25 09:17:42 |
| Message-ID: | 20200725091742.GA3510@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 25, 2020 at 07:22:15AM +0530, vignesh C wrote:
> I felt the changes look correct. The reason it might be working
> earlier is because the structure members are the same for both the
> data structures ECPGgeneric_bytea & ECPGgeneric_varchar.
ECPGset_noind_null() and ECPGis_noind_null() in misc.c show that
ECPGgeneric_bytea is attached to ECPGt_bytea. The two structures may
be the same now, but if a bug fix or a code change involves a change
in the structure definition we could run into problems. So let's fix
and back-patch this change. I am not spotting other areas impacted,
and I'll try to take care at the beginning of next week.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-25 09:32:07 | Re: display offset along with block number in vacuum errors |
| Previous Message | Amit Kapila | 2020-07-25 03:48:10 | Re: INSERT INTO SELECT, Why Parallelism is not selected? |