Re: [bug fix] pg_ctl always uses the same event source

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: MauMau <maumau307(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2014-01-24 05:11:49
Message-ID: CAA4eK1JHa-z-UjFdpQKhTxrR9oSFVUjyV2EuKY9D+fjkKYDq3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 24, 2014 at 4:22 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "MauMau" <maumau307(at)gmail(dot)com> writes:
>> From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>>> I'm still not clear on why we can't just use the port number.
>
>> To use port, we have to tell the location of $PGDATA to regsvr32.exe.
>
> [ scratches head... ] Exactly which of the other proposals *doesn't*
> require that?

Appending it with version number which is compile time constant.

> Certainly anything that involves parsing settings out
> of postgresql.conf will.

We don't need to parse for default value of event source, it is only
for case when user gives some specific name to event_source in
postgresql.conf and it that case, we expect that user provides the
same name during register command of event source, some thing
like:
regsvr32 /n /i: PostgreSQL_HEAD <install_dir_path>\lib\pgevent32.dll

Here point to note is that pgevent.dll never does any parsing or lookup
for event source name, either user provides it or we use default value.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-01-24 06:08:33 Re: ALTER TABLE lock strength reduction patch is unsafe
Previous Message Claudio Freire 2014-01-24 05:10:02 Re: Why do we let autovacuum give up?