| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "tomas(dot)vondra(at)2ndquadrant(dot)com" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] Optimize dropping of relation buffers using dlist |
| Date: | 2020-10-12 10:49:01 |
| Message-ID: | CAA4eK1JAAfthUBGodnphucehZU3PonoWhOenhytFXA_=trWVAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 12, 2020 at 3:08 PM k(dot)jamison(at)fujitsu(dot)com
<k(dot)jamison(at)fujitsu(dot)com> wrote:
>
> Hmm. When I repeated the performance measurement for non-recovery,
> I got almost similar execution results for both master and patched.
>
> Execution Time (in seconds)
> | s_b | master | patched | %reg |
> |-------|--------|---------|--------|
> | 128MB | 15.265 | 14.769 | -3.36% |
> | 1GB | 14.808 | 14.618 | -1.30% |
> | 20GB | 24.673 | 24.425 | -1.02% |
> | 100GB | 74.298 | 74.813 | 0.69% |
>
> That is considering that I removed the recovery-related checks in the patch and just
> executed the commands on a standalone server.
> - if (InRecovery && reln->smgr_cached_nblocks[forknum] != InvalidBlockNumber)
> + if (reln->smgr_cached_nblocks[forknum] != InvalidBlockNumber)
>
Why so? Have you tried to investigate? Check if it takes an optimized
path for the non-recovery case?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-10-12 11:11:32 | Re: Resetting spilled txn statistics in pg_stat_replication |
| Previous Message | Andrey Borodin | 2020-10-12 10:47:21 | Re: Deleting older versions in unique indexes to avoid page splits |