Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Keisuke Kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables
Date: 2020-10-16 02:49:37
Message-ID: CAA4eK1J8kZzz31N=t5pgicWFKh3Hxddd+jQ3SZb3Z4K-8pXuEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 16, 2020 at 2:00 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2020-10-15 12:38:49 +0530, Amit Kapila wrote:
> > On Wed, Oct 14, 2020 at 4:51 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > >
> > > On Wed, Oct 14, 2020 at 4:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > >
> > > >
> > > > Thanks for the tests. The latest patch looks mostly good to me. I have
> > > > made minor changes to the patch (a) changed the order where the new
> > > > message is placed at one place to make it consistent with other
> > > > places, (b) as discussed offlist, removed the extra increment to a
> > > > local variable in ReorderBufferRestoreChange, (c) ran pgindent.
> > > >
> > > > See the attached and let me know what do you think?
> > >
> > > The changes look good to me.
> > >
> >
> > Pushed!
>
> Awesome - it's great to see this problem finally addressed!
>

Thanks, I'm glad that you liked it.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-10-16 03:27:02 Re: gs_group_1 crashing on 13beta2/s390x
Previous Message Thomas Munro 2020-10-16 02:37:43 Re: upcoming API changes for LLVM 12