| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Question about building an exportable snapshop |
| Date: | 2021-10-20 11:36:15 |
| Message-ID: | CAA4eK1J8L2zydAKfyYdnMxY7xWMCi79vD56qvqt7238TZ4q1Ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 12, 2021 at 6:21 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> While working on the issue [1], I realize that if a subtransaction
> hasn't done any catalog change then we don't add this in the commit
> xid list even if we are building a full snapshot [2].
>
I think this is true only if we have reached SNAPBUILD_CONSISTENT
state otherwise, we are adding subtransactions in the committed xip
array by setting 'needs_timetravel' to true. And if we have already
reached a consistent state before it then we anyway don't need to add
this. If this is true, do you still see any problem?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-10-20 11:41:22 | Re: Question about building an exportable snapshop |
| Previous Message | Japin Li | 2021-10-20 11:12:04 | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |