| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Date: | 2017-05-25 14:00:58 |
| Message-ID: | CAA4eK1+YD5+kEoydYFH3Yi-MqU8+Vg3MDSi0KGMqjgzk0HGyHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 25, 2017 at 8:41 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Thu, May 25, 2017 at 11:41:19AM +0900, Michael Paquier wrote:
>
>> Indeed, pgrename() does so with a 100ms sleep time between each
>> iteration. Perhaps we could do that and limit to 50 iterations?
>
> pgrename() is polling for an asynchronous event, hence the sleep. To my
> knowledge, time doesn't heal shm attach failures; therefore, a sleep is not
> appropriate here.
>
Yes, I also share this opinion, the shm attach failures are due to
randomization behavior, so sleep won't help much. So, I will change
the patch to use 100 retries unless people have other opinions.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-05-25 14:18:21 | Re: No parameter values checking while creating Alter subscription...Connection |
| Previous Message | Robert Haas | 2017-05-25 13:55:09 | Re: pg_dump ignoring information_schema tables which used in Create Publication. |