| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Amit Kapila <akapila(at)postgresql(dot)org> |
| Subject: | Re: typos |
| Date: | 2022-04-11 10:45:23 |
| Message-ID: | CAA4eK1+VbJ62nfUtFk1gWadkv_Hw2vOK+uHyi1tZ1MQ0aXVkSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER
> > SUBSCRIPTION ... SKIP).
>
> Thank you for the patch! I've looked at 0012 patch. Regarding the
> following part:
>
> <function>pg_replication_origin_advance()</function></link> function
> - transaction. Before using this function, the subscription needs
> to be disabled
> + XXX? transaction. Before using this function, the subscription
> needs to be disabled
> temporarily either by <command>ALTER SUBSCRIPTION ...
> DISABLE</command> or, the
>
> we can remove "transaction", it seems a typo.
>
Right.
> The rest looks good to me.
>
+1. I'll take care of pushing this one tomorrow unless we have more
comments on this part.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2022-04-11 10:48:25 | Re: API stability |
| Previous Message | Amit Kapila | 2022-04-11 10:40:10 | Re: PG DOCS - logical replication filtering |