| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |
| Date: | 2016-06-18 03:48:21 |
| Message-ID: | CAA4eK1+S5KXVFHgeNzEqZU-jDR62uGMUkL-iFNA6KApySP2uUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Jun 18, 2016 at 8:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > Patch fixing the failures along with a new test case is attached with
this
> > mail
>
> That can't possibly be right, because the PathTarget.sortgrouprefs field
> is not a pointer to a Node.
>
Right.
>
> I think the two lines in question are just a poorly-thought-through case
> of premature optimization. If removing them makes the failures go away
> for me, that's what I plan to do.
>
That should make the failure go-away.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-18 04:29:01 | pgsql: Still another try at fixing scanjoin_target insertion into paral |
| Previous Message | Tom Lane | 2016-06-18 03:26:09 | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2016-06-18 04:09:39 | Re: New design for FK-based join selectivity estimation |
| Previous Message | Thomas Munro | 2016-06-18 03:28:18 | Assert(LWLockHeldByMeInMode(lock, LW_EXCLUSIVE)) |