| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |
| Date: | 2016-06-18 03:26:09 |
| Message-ID: | 9539.1466220369@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Patch fixing the failures along with a new test case is attached with this
> mail
That can't possibly be right, because the PathTarget.sortgrouprefs field
is not a pointer to a Node.
I think the two lines in question are just a poorly-thought-through case
of premature optimization. If removing them makes the failures go away
for me, that's what I plan to do.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-06-18 03:48:21 | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |
| Previous Message | Amit Kapila | 2016-06-18 03:16:23 | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2016-06-18 03:28:18 | Assert(LWLockHeldByMeInMode(lock, LW_EXCLUSIVE)) |
| Previous Message | Amit Kapila | 2016-06-18 03:16:23 | Re: pgsql: Try again to fix the way the scanjoin_target is used with partia |