| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: TerminateOtherDBBackends code comments inconsistency. |
| Date: | 2024-05-06 09:23:57 |
| Message-ID: | CAA4eK1+0yPCUukrLNo=xpf=2gpgZBjDe8KxoVCT1Gq2Vv1o0xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 30, 2024 at 10:36 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
>
> >
> > > One could argue the function should also check
> > > isBackgroundWorker and ignore even bgworkers that set proc->roleId, but I've
> > > not done that.
> >
> > What is the argument for ignoring such workers?
>
> One of the proposed code comments says, "For bgworker authors, it's convenient
> to be able to recommend FORCE if a worker is blocking DROP DATABASE
> unexpectedly." That argument is debatable, but I do think it applies equally
> to bgworkers whether or not they set proc->roleId.
>
Agreed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-05-06 09:48:42 | Re: wrong comment in libpq.h |
| Previous Message | Alexander Lakhin | 2024-05-06 09:00:00 | Test equivclass interferes with tests tsearch and advisory_lock |