Re: PATCH: PGADMIN 4 - FTS templates node

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: PGADMIN 4 - FTS templates node
Date: 2016-03-14 13:52:44
Message-ID: CA+yw=mPy7QqwWiR-MzMqyd+Zyjca1OBZuD5k_Z+CH6ore1A-vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I have incorporated your changes.
I have also tried to reproduce the Issues that you have mentioned.
find the response inline.

Also find revised patch having your suggested changes attached with this
mail.
Please do review it and let me know in case anything is missing.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Mar 11, 2016 at 6:41 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Mar 10, 2016 at 6:28 AM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA the patch for fts template after replacing collectionNodeModule with
> > SchemaChildModule in __init__.py
> >
> > Apart from that, there was an error while updating the name of fts
> template
> > which I have resolved in the same.
> >
> > Please do review it and let me know in case of any changes.
>
> I've updated the patch for consistency with others. Please find
> attached. Aside from those changes, there are two issues:
>
> - When creating or editing a template the SQL pane just says
> "--modified SQL" even when all required options are specified. The
> template is created correctly though.
>
I have tried to reproduce this issue on my system but could not reproduce
it. PFA screen shorts explaining sql I got while creating and editing a
template.

> - If a template is renamed, the treeview node is not updated.
>
This is generic issue and needed to be resolved at higher level.

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
image/png 23.1 KB
image/png 31.2 KB
fts_templatev5.patch text/x-patch 40.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-14 13:57:38 Re: PATCH: PGADMIN 4 - FTS templates node
Previous Message Muhammad Aqeel 2016-03-14 13:46:46 Re: PIP Package Building for pgAdmin4