| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: PGADMIN 4 - FTS templates node |
| Date: | 2016-03-11 13:11:28 |
| Message-ID: | CA+OCxoyZ68sU+hLm=THSd8afjAAxLZ0fB0fj-vtLPNvwABL-WA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Thu, Mar 10, 2016 at 6:28 AM, Sanket Mehta
<sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA the patch for fts template after replacing collectionNodeModule with
> SchemaChildModule in __init__.py
>
> Apart from that, there was an error while updating the name of fts template
> which I have resolved in the same.
>
> Please do review it and let me know in case of any changes.
I've updated the patch for consistency with others. Please find
attached. Aside from those changes, there are two issues:
- When creating or editing a template the SQL pane just says
"--modified SQL" even when all required options are specified. The
template is created correctly though.
- If a template is renamed, the treeview node is not updated.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| fts_templatev4-dave.patch | application/octet-stream | 38.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-03-11 13:19:44 | Re: [pgAdmin4][Patch]: Foreign Data Wrapper |
| Previous Message | Neel Patel | 2016-03-11 12:52:16 | Re: [pgAdmin4][Patch]: Foreign Data Wrapper |