Re: Please add timestamps to pgagent log

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgAdmin Support <pgadmin-support(at)postgresql(dot)org>
Subject: Re: Please add timestamps to pgagent log
Date: 2015-07-13 12:59:04
Message-ID: CA+yw=mNrOm5a0=a_9X7WOVJ2AiNb=5oG1MVBgb0m0g_PcQWiEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Hi ,

I have attached the patch which is having both functionalities (-v for
version info and timestamp in log)

Here timestamp is added only for linux platform because on windows pgagent
logs are viewed in event viewer which provides timestamp on its own.

Please do review it and let me know in case anything is missing.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, Jul 10, 2015 at 8:01 PM, Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com
> wrote:

> Sure Dave,
>
> I will look into it.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Fri, Jul 10, 2015 at 7:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Sanket - can you look at this please? As with Josh's request for
>> --version, it looks like we added this functionality to the PEM agent,
>> not pgAgent. You may copy the timestamp support for logging from the
>> PEM code to save effort.
>>
>> On Sat, Jul 4, 2015 at 7:23 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>> > Request:
>> >
>> > pgagent's output log current does not include timestamps. That makes it
>> > fairly hard to debug anything based on the log. Can we add a timestamp
>> > to the beginning of each log line?
>> >
>> > --
>> > Josh Berkus
>> > PostgreSQL Experts Inc.
>> > http://pgexperts.com
>> >
>> >
>> > --
>> > Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-support
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Attachment Content-Type Size
pgagent_version_timestamp.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2015-07-13 13:36:21 Re: Please add timestamps to pgagent log
Previous Message Josh Berkus 2015-07-10 16:41:21 Re: pgagent hangs forever in "r" state