Re: F8 for Execute to file

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Mads Jensen <mje(at)inducks(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: F8 for Execute to file
Date: 2014-10-28 07:39:14
Message-ID: CA+yw=mNcER8bqmD2zowf+oMFiZ3+863kEuVPOy3YJpdAYuZDHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I have reviewed this patch.
It looks good to me.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 27, 2014 at 4:16 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Ashesh, can you review/commit this please?
>
> On Fri, Oct 24, 2014 at 10:57 PM, Mads Jensen <mje(at)inducks(dot)org> wrote:
> > Hi,
> >
> > It's a trivial patch: I miss a shortcut key for this function, and thus
> > created a patch to support it.
> >
> > I don't get why this was:
> > wxAcceleratorTable accel(12, entries);
> > and not 14, as suggested in the manual:
> >
> > http://docs.wxwidgets.org/3.0/classwx_accelerator_table.html
> >
> > Thank you,
> > --
> > Med Venlig Hilsen / Kind regards,
> > Mads Jensen
> >
> > Max Jerry Horovitz: "Unfortunately, in America, babies are not found in
> > cola cans. I asked my mother when I was four and she said they came from
> > eggs laid by rabbis. If you aren't Jewish, they're laid by Catholic
> > nuns. If you're an atheist, they're laid by dirty, lonely prostitutes."
> > -- Mary and Max (2009)
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sanket Mehta 2014-10-28 09:29:19 Re: PATCH: Stored procedure large parameter list
Previous Message Sanket Mehta 2014-10-27 12:59:44 Re: PATCH: Fix Explain data output column not auto-sizing