Re: PATCH: Fix Explain data output column not auto-sizing

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: PATCH: Fix Explain data output column not auto-sizing
Date: 2014-10-27 12:59:44
Message-ID: CA+yw=mMh06eim7QOMy9w8gMY=eCyJVWJGiKBfTUtyVRHa1=eFg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I have reviewed the patch.
It looks good to me.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Ashesh, can you review/commit this please?
>
> On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
> > Hello!
> >
> > There is a small bug with Explain data output.
> >
> > Steps to reproduce:
> >
> > 1. Open a new Query window.
> > 2. Perform Explain of any query. Switch to "Data output" tab. Column
> > was auto-sized, ok.
> > 3. Execute the query.
> > 4. Perform Explain again. Switch to "Data output" tab. Column wasn't
> > auto-sized this time, it is too narrow and user has to resize it
> > manually.
> >
> > Here is a fix, please see attachment.
> >
> > --
> > Best regards,
> > J.F.
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sanket Mehta 2014-10-28 07:39:14 Re: F8 for Execute to file
Previous Message Akshay Joshi 2014-10-27 10:58:06 Re: [pgadmin-hackers] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3