Re: PATCH: Clear undo/redo history when a file is opened in Query editor

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: PATCH: Clear undo/redo history when a file is opened in Query editor
Date: 2014-10-28 09:59:14
Message-ID: CA+yw=mN0K6kGEfpW8ROdwD5utvJOvNPCsaQhV559Yp_O-odgLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

As per my understanding below is the bug scenario.

- open any file in sql editor..
- now open a second file in same editor and try undo.
- it will show you previous file content again.

Let me know if my understanding is correct so that i can go ahead and
review the patch.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 27, 2014 at 4:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Ashesh, can you review/commit this please?
>
> On Fri, Oct 24, 2014 at 8:35 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
> > Hello!
> >
> > A user may occasionaly assign content of a previously edited file into
> > a next file opened in the same Query window, by calling Undo and Save.
> >
> > Simple non-MDI text editors (for example, notepad.exe) prevent an
> > issue by clearing undo/redo history, so should we do.
> > Please see the attached patch.
> >
> > --
> > Best regards,
> > J.F.
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sanket Mehta 2014-10-28 10:27:29 Re: PATCH: Support smallserial columns in Edit Data window
Previous Message Sanket Mehta 2014-10-28 09:29:19 Re: PATCH: Stored procedure large parameter list