| From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
|---|---|
| To: | Cary Huang <cary(dot)huang(at)highgo(dot)ca> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
| Subject: | Re: encode/decode support for base64url |
| Date: | 2025-03-11 08:08:06 |
| Message-ID: | CA+v5N42+jMReUkx987P3ORKBFXyM1L7qG1sWUyVA-qbFco_v_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 11, 2025 at 12:51 AM Cary Huang <cary(dot)huang(at)highgo(dot)ca> wrote:
> > Oh well - you're probably right.
> > I guess I was blinded by my convenience.
> > Adding a 'base64url' option there is more appropriate.
>
> I agree with it too. It is neater to add "base64url" as a new option for
> encode() and decode() SQL functions in encode.c.
>
Attaching a v2 with that.
>
> In addition, you may also want to add the C versions of base64rul encode
> and decode functions to "src/common/base64.c" as new API calls so that
> the frontend, backend applications and extensions can also have access
> to these base64url conversions.
>
>
We could expose this in base64.c - it'll need some more checking
A few more test cases, especially around padding, are necessary.
I'll come back to this.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-base64url-in-encode-decode-functions.patch | application/octet-stream | 7.3 KB |
| v2-0002-Fix-declaration-after-statement.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-03-11 08:23:42 | Re: Emitting JSON to file using COPY TO |
| Previous Message | Yuki Seino | 2025-03-11 07:50:06 | Re: Add “FOR UPDATE NOWAIT” lock details to the log. |